[all-commits] [llvm/llvm-project] b3a53c: [NFC][TableGen] Code cleanup in Wasm disassember e...

Rahul Joshi via All-commits all-commits at lists.llvm.org
Thu Apr 17 13:42:56 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b3a53cc721807f0cd0e3a1e6ddda03a85c774d4f
      https://github.com/llvm/llvm-project/commit/b3a53cc721807f0cd0e3a1e6ddda03a85c774d4f
  Author: Rahul Joshi <rjoshi at nvidia.com>
  Date:   2025-04-17 (Thu, 17 Apr 2025)

  Changed paths:
    M llvm/lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp
    M llvm/utils/TableGen/WebAssemblyDisassemblerEmitter.cpp

  Log Message:
  -----------
  [NFC][TableGen] Code cleanup in Wasm disassember emitter (#135992)

- Use range for loop to iterate over instructions.
- Emit generated code in anonymous namespace instead of `llvm` and
reduce the scope of this to just the type declarations.
- Emit generated tables as static constexpr
- Replace code to search in operand table with `std::search`.
- Skip the last "null" entry in PrefixTable and use range for loop to
search PrefixTable in the .cpp code.
- Do not generate `WebAssemblyInstructionTableSize` definition as its
already defined in the .cpp file.
- Remove {} for single statement loop/if/else bodies.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list