[all-commits] [llvm/llvm-project] 183cb4: [lldb-dap] Fixing a race during disconnect. (#135872)

[John Harrison via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 183cb45c1280b80a0022649d1db8a93544bb97b0
      https://github.com/llvm/llvm-project/commit/183cb45c1280b80a0022649d1db8a93544bb97b0
  Author: John Harrison <harjohn at google.com>
  Date:   2025-04-16 (Wed, 16 Apr 2025)

  Changed paths:
    M lldb/tools/lldb-dap/DAP.cpp

  Log Message:
  -----------
  [lldb-dap] Fixing a race during disconnect. (#135872)

While attempting to disconnect the DAP transport reader thread is
setting
`disconnecting` as soon as it sees a [disconnect
request](https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Disconnect).

However, if it is processing another request when this disconnect
arrives the `DAP::Loop` handler may exit the loop without replying to
the disconnect request.

There has been some instability on the CI jobs due to this race, for
example https://lab.llvm.org/buildbot/#/builders/59/builds/16076

To address this, ensure we only return from `DAP::Loop` once we've
emptied the queue.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications