[all-commits] [llvm/llvm-project] 98534e: [mlir] Migrate away from PointerUnion::dyn_cast (N...

Kazu Hirata via All-commits all-commits at lists.llvm.org
Tue Apr 15 09:10:41 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 98534eee847dfa80ff88b213a628a6149f8754d9
      https://github.com/llvm/llvm-project/commit/98534eee847dfa80ff88b213a628a6149f8754d9
  Author: Kazu Hirata <kazu at google.com>
  Date:   2025-04-15 (Tue, 15 Apr 2025)

  Changed paths:
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

  Log Message:
  -----------
  [mlir] Migrate away from PointerUnion::dyn_cast (NFC) (#135770)

Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:

  // FIXME: Replace the uses of is(), get() and dyn_cast() with
  //        isa<T>, cast<T> and the llvm::dyn_cast<T>

Literal migration would result in dyn_cast_if_present (see the
definition of PointerUnion::dyn_cast), but this patch uses dyn_cast
because we have a call to dyn_cast earlier in the function, implying
that attrOrProp is nonnull.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list