[all-commits] [llvm/llvm-project] 18fdda: [GlobalISel] Diagnose inline assembly constraint l...

Pierre van Houtryve via All-commits all-commits at lists.llvm.org
Tue Apr 15 05:12:30 PDT 2025


  Branch: refs/heads/users/pierre-vh/gisel-inlineasm-constraint-diag
  Home:   https://github.com/llvm/llvm-project
  Commit: 18fddacf58da2b2628fdfa5a30b4b59ec67ec35b
      https://github.com/llvm/llvm-project/commit/18fddacf58da2b2628fdfa5a30b4b59ec67ec35b
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2025-04-15 (Tue, 15 Apr 2025)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp

  Log Message:
  -----------
  [GlobalISel] Diagnose inline assembly constraint lowering errors

Instead of printing something to dbgs (which is not visible to all users),
emit a diagnostic like the DAG does. We still crash later because we fail to
select the inline assembly, but at least now users will know why it's crashing.

In a future patch we could also recover from the error like the DAG does, so the
lowering can keep going until it either crashes or gives a different error later.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list