[all-commits] [llvm/llvm-project] e2c400: [clang] consistently quote expressions in diagnostics

[Matheus Izvekov via All-commits]

  Branch: refs/heads/users/mizvekov/diag-expr-quoted
  Home:   https://github.com/llvm/llvm-project
  Commit: e2c40042553845125914e544e696d7e21b553e7d
      https://github.com/llvm/llvm-project/commit/e2c40042553845125914e544e696d7e21b553e7d
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2025-04-15 (Tue, 15 Apr 2025)

  Changed paths:
    M clang/docs/InternalsManual.rst
    M clang/docs/ReleaseNotes.rst
    M clang/include/clang/Basic/DiagnosticASTKinds.td
    M clang/include/clang/Basic/DiagnosticParseKinds.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/AST/ASTDiagnostic.cpp
    M clang/lib/Basic/Diagnostic.cpp
    M clang/lib/Sema/SemaChecking.cpp
    M clang/test/AST/ByteCode/literals.cpp
    M clang/test/C/C11/n1285.c
    M clang/test/CodeGenCXX/sections.cpp
    A clang/test/FixIt/fixit-bool.cpp
    M clang/test/Modules/odr_hash.cpp
    M clang/test/OpenMP/declare_variant_messages.c
    M clang/test/OpenMP/declare_variant_messages.cpp
    M clang/test/OpenMP/distribute_parallel_for_simd_linear_messages.cpp
    M clang/test/OpenMP/distribute_simd_linear_messages.cpp
    M clang/test/OpenMP/for_linear_messages.cpp
    M clang/test/OpenMP/for_simd_linear_messages.cpp
    M clang/test/OpenMP/for_simd_misc_messages.c
    M clang/test/OpenMP/masked_taskloop_simd_linear_messages.cpp
    M clang/test/OpenMP/master_taskloop_simd_linear_messages.cpp
    M clang/test/OpenMP/parallel_for_linear_messages.cpp
    M clang/test/OpenMP/parallel_for_simd_linear_messages.cpp
    M clang/test/OpenMP/parallel_for_simd_misc_messages.c
    M clang/test/OpenMP/parallel_masked_taskloop_simd_linear_messages.cpp
    M clang/test/OpenMP/parallel_master_taskloop_simd_linear_messages.cpp
    M clang/test/OpenMP/simd_linear_messages.cpp
    M clang/test/OpenMP/simd_misc_messages.c
    M clang/test/OpenMP/target_parallel_for_linear_messages.cpp
    M clang/test/OpenMP/target_parallel_for_simd_linear_messages.cpp
    M clang/test/OpenMP/target_simd_linear_messages.cpp
    M clang/test/OpenMP/target_teams_distribute_parallel_for_simd_linear_messages.cpp
    M clang/test/OpenMP/target_teams_distribute_simd_linear_messages.cpp
    M clang/test/OpenMP/task_affinity_messages.cpp
    M clang/test/OpenMP/task_depend_messages.cpp
    M clang/test/OpenMP/taskloop_simd_linear_messages.cpp
    M clang/test/OpenMP/teams_distribute_parallel_for_simd_linear_messages.cpp
    M clang/test/OpenMP/teams_distribute_simd_linear_messages.cpp
    M clang/test/Sema/code_align.c
    M clang/test/Sema/warn-int-in-bool-context.c
    M clang/test/Sema/warn-lifetime-analysis-nocfg.cpp
    M clang/test/SemaCXX/attr-lifetime-capture-by.cpp
    M clang/test/SemaCXX/attr-lifetimebound.cpp
    M clang/test/SemaCXX/cxx2c-pack-indexing.cpp
    M clang/test/SemaCXX/warn-dangling-local.cpp
    M clang/test/SemaHLSL/BuiltIns/asuint-errors.hlsl
    M clang/test/SemaHLSL/BuiltIns/select-errors.hlsl
    M clang/test/SemaHLSL/BuiltIns/splitdouble-errors.hlsl
    M clang/test/SemaHLSL/Language/OutputParameters.hlsl
    M clang/test/SemaHLSL/parameter_modifiers.hlsl
    M clang/test/SemaOpenCL/to_addr_builtin.cl
    M clang/utils/TableGen/ClangDiagnosticsEmitter.cpp

  Log Message:
  -----------
  [clang] consistently quote expressions in diagnostics

This changes the expression diagnostic printer to always add quotes,
and removes hardcoded quotes from the diagnostic format strings.

In some cases, a placeholder could be filled by either an expression
or as a string. In order to quote this consistently, a new modifier
was added, which can be used to quote strings.

One diagnostic was relying on unquoted expressions in order to
generate code suggestions. This diagnostic is converted to use fixit
hints instead.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications