[all-commits] [llvm/llvm-project] b9a3e9: [Clang]Ensure correct handling of cleanup access c...

[Oliver Hunt via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b9a3e998b1921f7d1e3093f27d288ee1a121ba4b
      https://github.com/llvm/llvm-project/commit/b9a3e998b1921f7d1e3093f27d288ee1a121ba4b
  Author: Oliver Hunt <oliver at apple.com>
  Date:   2025-04-14 (Mon, 14 Apr 2025)

  Changed paths:
    M clang/lib/Sema/SemaExprCXX.cpp
    A clang/test/CodeGenCXX/bug135668.cpp
    A clang/test/SemaCXX/bug135668.cpp

  Log Message:
  -----------
  [Clang]Ensure correct handling of cleanup access control  (#135668) (#135686)

The P2719 implementation refactored diagnostics for cleanup delete, and
as part of that I attempted to fix handling of inaccessible cleanup
operator delete. Alas the new branch was incorrect as it was performing
an implicit bool conversion, which resulted in friend accessible cleanup
operators incorrectly being considered erroneous and the allocation path
errored out. This error however did not get diagnosed, so the result was
and so we did not actually error out before codegen.

Added both Sema and CodeGen tests to cover this.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications