[all-commits] [llvm/llvm-project] 62be33: [Clang]Ensure correct handling of access control i...

[Oliver Hunt via All-commits]

  Branch: refs/heads/users/ojhunt/bug135668
  Home:   https://github.com/llvm/llvm-project
  Commit: 62be33b3aa475a33d1c11679ed069eb2af981754
      https://github.com/llvm/llvm-project/commit/62be33b3aa475a33d1c11679ed069eb2af981754
  Author: Oliver Hunt <oliver at apple.com>
  Date:   2025-04-14 (Mon, 14 Apr 2025)

  Changed paths:
    M clang/lib/Sema/SemaExprCXX.cpp
    A clang/test/CodeGenCXX/bug135668.cpp
    A clang/test/SemaCXX/bug135668.cpp

  Log Message:
  -----------
  [Clang]Ensure correct handling of access control in P2719 diagnostics (#135668)

The P2719 implementation refactored diagnostics for cleanup delete, and as
part of that I attempted to fix handling of inaccessible cleanup operator
delete. Alas the new branch was incorrect as it was performing an implicit
bool conversion, which resulted in friend accessible cleanup operators
incorrectly being considered erroneous and the allocation path errored out.
This error however did not get diagnosed, so the result was and so we did
not actually error out before codegen.

Added both Sema and CodeGen tests to cover this.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications