[all-commits] [llvm/llvm-project] 773413: [mlir][OpenMP] allow cancellation to not be direct...

Tom Eccles via All-commits all-commits at lists.llvm.org
Mon Apr 14 02:39:24 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 77341388a77b1442b3a54d745fc269dabb175f0c
      https://github.com/llvm/llvm-project/commit/77341388a77b1442b3a54d745fc269dabb175f0c
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2025-04-14 (Mon, 14 Apr 2025)

  Changed paths:
    M mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
    M mlir/test/Dialect/OpenMP/invalid.mlir
    M mlir/test/Dialect/OpenMP/ops.mlir

  Log Message:
  -----------
  [mlir][OpenMP] allow cancellation to not be directly nested (#134084)

omp.cancel and omp.cancellationpoint contain an attribute describing the
type of parent construct which should be cancelled. e.g.
```
!$omp cancel do
```
Must be inside of a wsloop. Previously the verifer required the
immediate parent to be this operation. This is not quite right because
something like the following is valid:
```
!$omp parallel do
do i = 1, N
  if (cond) then
    !$omp cancel do
  endif
enddo
```

This patch relaxes the verifier to only require that some parent
operation matches (not necessarily the immediate parent).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list