[all-commits] [llvm/llvm-project] 95d526: [MLIR][Tosa] Fix argmax NaN propagate lowering (#1...

[RoboTux via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 95d526f7f587cc7a3db785169967f8dad0ba3978
      https://github.com/llvm/llvm-project/commit/95d526f7f587cc7a3db785169967f8dad0ba3978
  Author: Thomas Preud'homme <thomas.preudhomme at arm.com>
  Date:   2025-04-14 (Mon, 14 Apr 2025)

  Changed paths:
    M mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp
    M mlir/test/Conversion/TosaToLinalg/tosa-to-linalg.mlir

  Log Message:
  -----------
  [MLIR][Tosa] Fix argmax NaN propagate lowering (#133074)

In the propagate mode, NaN compare equal to each other so in case of
several NaNs the index of the first one needs to be returned. This
commit changes the index update condition to check that the current
index is not that of a NaN.

The commit also simplifies argmax NaN ignore lowering to only use OGT.
This prevent any update in case of NaN. The only case where the index of
a NaN is returned is when all values are NaN and this is covered by the
fact that the initial index value is 0 so no update will result in 0
being returned.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications