[all-commits] [llvm/llvm-project] 634f9a: ARMAsmBackend: Use fixupNeedsRelaxationAdvanced. NFC

Fangrui Song via All-commits all-commits at lists.llvm.org
Sun Apr 13 15:55:33 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 634f9a981571eae000c1adc311014c5c64486187
      https://github.com/llvm/llvm-project/commit/634f9a981571eae000c1adc311014c5c64486187
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-04-13 (Sun, 13 Apr 2025)

  Changed paths:
    M llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
    M llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.h

  Log Message:
  -----------
  ARMAsmBackend: Use fixupNeedsRelaxationAdvanced. NFC

This prepares for the upcoming change to simplify relocation recording
in MCAssembler.

While both MCAssembler::fixupNeedsRelaxation and
MCAssembler::handleFixup call evaluateFixup and use
shouldForceRelocation, the shouldForceRelocation logic is not supposed
to be needed by MCAssembler::fixupNeedsRelaxation.

The ARM special cases for interworking branches
(https://reviews.llvm.org/D33436 and https://reviews.llvm.org/D33898)
break the assumption. Switch to fixupNeedsRelaxationAdvanced and
explicitly test the conditions.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list