[all-commits] [llvm/llvm-project] d6e2ae: Revert "[tosa]: canonicalize dynamic size of tosa....

Thurston Dang via All-commits all-commits at lists.llvm.org
Sun Apr 13 00:07:50 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d6e2aee9b1069b4a5fc1a0b07aef23b380f856f6
      https://github.com/llvm/llvm-project/commit/d6e2aee9b1069b4a5fc1a0b07aef23b380f856f6
  Author: Thurston Dang <thurston at google.com>
  Date:   2025-04-13 (Sun, 13 Apr 2025)

  Changed paths:
    M mlir/lib/Dialect/Tosa/IR/TosaCanonicalizations.cpp
    M mlir/test/Dialect/Tosa/canonicalize.mlir

  Log Message:
  -----------
  Revert "[tosa]: canonicalize dynamic size of tosa.slice to static output shape" (#135525)

Reverts llvm/llvm-project#135429 due buildbot breakage:
https://lab.llvm.org/buildbot/#/builders/169/builds/10405

Based on the ASan output, I think after the replaceOp on line 775, it's
no longer valid to do getSize() on sliceOp:
```
   775      rewriter.replaceOp(sliceOp, newSliceOp.getResult());
   776
   777      // Remove const_shape size op when it no longer has use point.
   778      Operation *sizeConstShape = sliceOp.getSize().getDefiningOp();
```



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list