[all-commits] [llvm/llvm-project] 396629: MCObjectStreamer: Refine absoluteSymbolDiff condition

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 39662922e15c53f54da93b5a1d029589d49caec9
      https://github.com/llvm/llvm-project/commit/39662922e15c53f54da93b5a1d029589d49caec9
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-04-12 (Sat, 12 Apr 2025)

  Changed paths:
    M llvm/lib/MC/MCObjectStreamer.cpp

  Log Message:
  -----------
  MCObjectStreamer: Refine absoluteSymbolDiff condition

The function is called to test the fast path - when Lo/Hi are within the
same fragment. This is unsafe - Lo/Hi at the begin and end of a
relaxable fragment should not evaluate to a constant. However, we don't
have tests that exercise the code path.

Nevertheless, make the check safer and remove the now unnecessary
isRISCV check (from https://reviews.llvm.org/D103539).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications