[all-commits] [llvm/llvm-project] 5aabbe: Reland: [clang] Improved canonicalization for temp...

[Matheus Izvekov via All-commits]

  Branch: refs/heads/users/mizvekov/tst-refactor
  Home:   https://github.com/llvm/llvm-project
  Commit: 5aabbe8a11bee5e5b35fa9ef9134d45498bbb4a6
      https://github.com/llvm/llvm-project/commit/5aabbe8a11bee5e5b35fa9ef9134d45498bbb4a6
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2025-04-12 (Sat, 12 Apr 2025)

  Changed paths:
    M clang-tools-extra/clangd/AST.cpp
    M clang/docs/ReleaseNotes.rst
    M clang/include/clang/AST/ASTContext.h
    M clang/include/clang/AST/PropertiesBase.td
    M clang/include/clang/AST/TemplateBase.h
    M clang/include/clang/AST/Type.h
    M clang/include/clang/AST/TypeProperties.td
    M clang/lib/AST/ASTContext.cpp
    M clang/lib/AST/ASTDiagnostic.cpp
    M clang/lib/AST/ASTImporter.cpp
    M clang/lib/AST/DeclTemplate.cpp
    M clang/lib/AST/QualTypeNames.cpp
    M clang/lib/AST/TemplateBase.cpp
    M clang/lib/AST/Type.cpp
    M clang/lib/Sema/SemaCXXScopeSpec.cpp
    M clang/lib/Sema/SemaExpr.cpp
    M clang/lib/Sema/SemaLookup.cpp
    M clang/lib/Sema/SemaTemplate.cpp
    M clang/lib/Sema/SemaTemplateDeduction.cpp
    M clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
    M clang/lib/Sema/SemaTemplateVariadic.cpp
    M clang/lib/Sema/TreeTransform.h
    M clang/test/CXX/class.derived/class.derived.general/p2.cpp
    M clang/test/CXX/temp/temp.decls/temp.class.spec/p6.cpp
    M clang/test/SemaCXX/undefined-partial-specialization.cpp
    M clang/test/SemaTemplate/make_integer_seq.cpp
    M clang/test/SemaTemplate/type_pack_element.cpp
    M clang/unittests/AST/TypePrinterTest.cpp

  Log Message:
  -----------
  Reland: [clang] Improved canonicalization for template specialization types

This changes the TemplateArgument representation to hold a flag indicating
whether a tempalte argument of expression type is supposed to be canonical
or not.

This gets one step closer to solving https://github.com/llvm/llvm-project/issues/92292

This still doesn't try to unique as-written TSTs. While this would
increase the amount of memory savings and make code dealing with
the AST more well-behaved, profiling template argument lists is
still too expensive for this to be worthwhile, at least for now.

This also fixes the context creation of TSTs, so that they don't
in some cases get incorrectly flagged as sugar over their own canonical
form. This is captured in the test expectation change of some AST dumps.

This fixes some places which were unnecessarily canonicalizing these TSTs.


  Commit: 8006825509008cf5326cf6744d3e065d05c0d6da
      https://github.com/llvm/llvm-project/commit/8006825509008cf5326cf6744d3e065d05c0d6da
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2025-04-12 (Sat, 12 Apr 2025)

  Changed paths:
    M clang/include/clang/AST/ASTContext.h
    M clang/include/clang/AST/Type.h
    M clang/lib/AST/ASTContext.cpp
    M clang/lib/AST/Type.cpp

  Log Message:
  -----------
  [clang] ASTContext: fix creation of UnaryTransformTypes

This makes sure UnaryTransformTypes are all uniqued,
which makes the AST node more well behaved, and helps
with aka suppression in diagnostics.

This also makes sure a canonical UnaryTransformType round trips
back to a canonical type when recreated from its components.


  Commit: 3f4fc1d3cc40384aedbc0b7193a816c9ff289204
      https://github.com/llvm/llvm-project/commit/3f4fc1d3cc40384aedbc0b7193a816c9ff289204
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2025-04-12 (Sat, 12 Apr 2025)

  Changed paths:
    M clang/include/clang/AST/Type.h
    M clang/lib/AST/ASTContext.cpp
    M clang/lib/AST/Type.cpp

  Log Message:
  -----------
  [clang] ASTContext: make DecltypeType creation more well-behaved

This makes sure a canonical DecltypeType round-trips back to a
canonical type when rebuilt from its components.


  Commit: d1a9483e8f39cb1dc73e6192b19f3a2524b64faf
      https://github.com/llvm/llvm-project/commit/d1a9483e8f39cb1dc73e6192b19f3a2524b64faf
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2025-04-12 (Sat, 12 Apr 2025)

  Changed paths:
    M clang/lib/AST/ASTStructuralEquivalence.cpp

  Log Message:
  -----------
  fix structural comparison of DependentTemplateStorage


Compare: https://github.com/llvm/llvm-project/compare/338a8368c402...d1a9483e8f39

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications