[all-commits] [llvm/llvm-project] 72364b: [clang] fix serialization for SubstNonTypeTemplate...

[Matheus Izvekov via All-commits]

  Branch: refs/heads/users/mizvekov/subst-pack-fix-serialization-final
  Home:   https://github.com/llvm/llvm-project
  Commit: 72364b18f0cfc44219d73f648618eb4a190b4a3d
      https://github.com/llvm/llvm-project/commit/72364b18f0cfc44219d73f648618eb4a190b4a3d
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2025-04-11 (Fri, 11 Apr 2025)

  Changed paths:
    M clang/lib/Serialization/ASTReaderStmt.cpp
    M clang/lib/Serialization/ASTWriterStmt.cpp

  Log Message:
  -----------
  [clang] fix serialization for SubstNonTypeTemplateParmPackExpr

This fixes a PCM non-determinism regression reported here:
https://github.com/llvm/llvm-project/pull/134560#issuecomment-2797744370

There was a bit in `SubstNonTypeTemplateParmPackExpr` which we missed
to serialize, and that bit eventually propagates to
`SubstNonTypeTemplateParmExpr`.

As a drive by, improve serialization for PackIndex on SubstNonTypeTemplateParmExpr
by using the newly introduced UnsignedOrNone helpers.

There are no release notes since this regression was never released.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications