[all-commits] [llvm/llvm-project] 968955: Reapply [Metadata] Preserve MD_prof when merging i...

[Snehasish Kumar via All-commits]

  Branch: refs/heads/users/snehasish/reapply-metadata
  Home:   https://github.com/llvm/llvm-project
  Commit: 96895580e46f4b44adc34e803d5b97344b1ba515
      https://github.com/llvm/llvm-project/commit/96895580e46f4b44adc34e803d5b97344b1ba515
  Author: Snehasish Kumar <snehasishk at google.com>
  Date:   2025-04-11 (Fri, 11 Apr 2025)

  Changed paths:
    M llvm/lib/IR/Metadata.cpp
    M llvm/lib/Transforms/Utils/Local.cpp
    A llvm/test/Transforms/GVN/pre-invalid-prof-metadata.ll
    A llvm/test/Transforms/SimplifyCFG/merge-direct-call-branch-weights-preserve-hoist.ll
    A llvm/test/Transforms/SimplifyCFG/merge-direct-call-branch-weights-preserve-sink.ll

  Log Message:
  -----------
  Reapply [Metadata] Preserve MD_prof when merging instructions when one is missing.

Preserve branch weight metadata when merging instructions if one of the
instructions is missing metadata. This is similar in behaviour to what
we do today for other types of metadata such as mmra, memprof and
callsite metadata.

Also add a legality check when merging prof metadata based on
instruction type. Without this check GVN PRE optimizations result in
prof metadata on phi nodes which break the module verifier.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications