[all-commits] [llvm/llvm-project] 58211f: [llvm-reduce] Fix incorrectly ignored null MD in R...

[Stephen Tozer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 58211f55c5d42394b3de3310a825d707e7622833
      https://github.com/llvm/llvm-project/commit/58211f55c5d42394b3de3310a825d707e7622833
  Author: Stephen Tozer <stephen.tozer at sony.com>
  Date:   2025-04-11 (Fri, 11 Apr 2025)

  Changed paths:
    A llvm/test/tools/llvm-reduce/108541-null-metadata-crash.ll
    M llvm/tools/llvm-reduce/deltas/ReduceDIMetadata.cpp

  Log Message:
  -----------
  [llvm-reduce] Fix incorrectly ignored null MD in ReduceDIMetadata (#108541)

Commit c2e62c7 updated the ReduceDIMetadata pass to be able to remove
DIGlobalVariableExpressions from MDNode operands; it also accidentally
prevented null operands from being preserved, which results in an
assertion being triggered:
`Targets == NoChunksCounter.count() && "number of chunks changes when
reducing"'

This patch allows us to correctly preserve null operands once again.
I've not got a test case for this yet - I'm hoping this patch is just
trivially correct as-is, because I've not got the hang of reducing a
test case for llvm-reduce yet, but I can get a test case generated if
needed.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications