[all-commits] [llvm/llvm-project] 2f7e68: [MLIR] Ensure deterministic parallel verification ...

[Nachi G via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2f7e685e3d8813ca584cc2f278ac3cd57b43772d
      https://github.com/llvm/llvm-project/commit/2f7e685e3d8813ca584cc2f278ac3cd57b43772d
  Author: Nachi G <nacgarg at users.noreply.github.com>
  Date:   2025-04-09 (Wed, 09 Apr 2025)

  Changed paths:
    M mlir/lib/IR/Verifier.cpp
    M mlir/test/IR/invalid-ops.mlir

  Log Message:
  -----------
  [MLIR] Ensure deterministic parallel verification (#134963)

`failableParallelForEach` will non-deterministically early terminate
upon failure, leading to inconsistent and potentially missing
diagnostics.

This PR uses `parallelForEach` to ensure all operations are verified and
all diagnostics are handled, while tracking the failure state
separately.

Other potential fixes include:
- Making `failableParallelForEach` have deterministic early-exit
behavior (or have an option for it)
- I didn't want to change more than what was required (and potentially
incur perf hits for unrelated code), but if this is a better fix I'm
happy to submit a patch.
- I think all diagnostics that can be detected from verification
failures should be reported, so I don't even think this would be correct
behavior anyway

- Adding an option for `failableParallelForEach` to still execute on
every element on the range while still returning `LogicalResult`



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications