[all-commits] [llvm/llvm-project] df28c8: [lldb][debugserver] Fix an off-by-one error in wat...

[Jason Molenda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: df28c81f5a2b61a3b5ad1e6274dd27697a9367ac
      https://github.com/llvm/llvm-project/commit/df28c81f5a2b61a3b5ad1e6274dd27697a9367ac
  Author: Jason Molenda <jmolenda at apple.com>
  Date:   2025-04-07 (Mon, 07 Apr 2025)

  Changed paths:
    A lldb/test/API/functionalities/watchpoint/consecutive-watchpoints/Makefile
    A lldb/test/API/functionalities/watchpoint/consecutive-watchpoints/TestConsecutiveWatchpoints.py
    A lldb/test/API/functionalities/watchpoint/consecutive-watchpoints/main.c
    M lldb/tools/debugserver/source/DNBBreakpoint.cpp

  Log Message:
  -----------
  [lldb][debugserver] Fix an off-by-one error in watchpoint identification (#134314)

debugserver takes the address of a watchpoint exception and calculates
which watchpoint was responsible for it. There was an off-by-one error
in the range calculation which causes two watchpoints on consecutive
ranges to not correctly identify hits to the second watchpoint. The
result is that lldb wouldn't show the second watchpoint as ever being
hit.

Re-landing this test with a modification to only require two
watchpoints in the test, instead of four.  If four watchpoints can
be set, it will test them.

rdar://145107575



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications