[all-commits] [llvm/llvm-project] 87a421: [Clang] Always verify LLVM IR inputs (#134396)

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 87a4215ed154e867683b10c8d7fe1dbc79d81abb
      https://github.com/llvm/llvm-project/commit/87a4215ed154e867683b10c8d7fe1dbc79d81abb
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2025-04-07 (Mon, 07 Apr 2025)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticFrontendKinds.td
    M clang/lib/CodeGen/CodeGenAction.cpp
    A clang/test/CodeGen/invalid_llvm_ir.ll

  Log Message:
  -----------
  [Clang] Always verify LLVM IR inputs (#134396)

We get a lot of issues that basically boil down to "I passed malformed
LLVM IR to clang and it crashed". Clang does not perform IR verification
by default in (non-assertion-enabled) release builds, and that's
sensible for IR that Clang itself produces, which is expected to always
be valid. However, if people pass in their own handwritten IR, we should
report if it is malformed, instead of crashing. We should also report it
in a way that does not produce a crash trace and ask for a bug report,
as currently happens in assertions-enabled builds. This aligns the
behavior with how opt/llc work.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications