[all-commits] [llvm/llvm-project] 55ff96: [X86][Test] Reorder PassMgrF and OS. (#134481)

weiwei chen via All-commits all-commits at lists.llvm.org
Sat Apr 5 16:42:15 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 55ff96abfa08ec94b0f8f4ebe187a3232e9d92b7
      https://github.com/llvm/llvm-project/commit/55ff96abfa08ec94b0f8f4ebe187a3232e9d92b7
  Author: weiwei chen <weiwei.chen at modular.com>
  Date:   2025-04-05 (Sat, 05 Apr 2025)

  Changed paths:
    M llvm/unittests/CodeGen/X86MCInstLowerTest.cpp

  Log Message:
  -----------
  [X86][Test] Reorder PassMgrF and OS. (#134481)

Reordering `OS` and `PassMgrF` should fix the asan failure that's caused
by OS being destroyed before `PassMgrF` deletes the AsmPrinter.

As shown in[ this asan run
](https://lab.llvm.org/buildbot/#/builders/52/builds/7340/steps/12/logs/stdio)

```
  This frame has 15 object(s):
    [32, 48) 'PassMgrF' (line 154)
    [64, 1112) 'Buf' (line 155)
    [1248, 1304) 'OS' (line 156) <== Memory access at offset 1280 is inside this variable
```
which indicates an ordering problem. 

This should help to fix all the sanitizer failures caused by the test
`X86MCInstLowerTest.cpp` that's introduced by [this
PR](https://github.com/llvm/llvm-project/pull/133352#issuecomment-2780173791).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list