[all-commits] [llvm/llvm-project] b6a961: [MCParser] Rename confusing variable names

Fangrui Song via All-commits all-commits at lists.llvm.org
Fri Apr 4 21:04:29 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b6a96183015e99ec554f7a6b8c35a0e679b8ba39
      https://github.com/llvm/llvm-project/commit/b6a96183015e99ec554f7a6b8c35a0e679b8ba39
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-04-04 (Fri, 04 Apr 2025)

  Changed paths:
    M llvm/include/llvm/MC/MCParser/AsmLexer.h
    M llvm/lib/MC/MCParser/AsmParser.cpp
    M llvm/lib/MC/MCParser/MasmParser.cpp
    M llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp

  Log Message:
  -----------
  [MCParser] Rename confusing variable names

https://reviews.llvm.org/D24047 added `IsAtStartOfStatement` to
MCAsmLexer, while its subclass AsmLexer had a variable of the same name.
The assignment in `UnLex` is unnecessary, which is now removed.

60b403e75cd25a0c76aaaf4e6b176923acf49443 (2019) named the result
`parseStatement` `Parsed`. `HasError` is a clearer name.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list