[all-commits] [llvm/llvm-project] 74a780: [lld-macho] Fix code section ordering in output bi...

[alx32 via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 74a78028932f5e26c93dc6fd7efab65b97e6824c
      https://github.com/llvm/llvm-project/commit/74a78028932f5e26c93dc6fd7efab65b97e6824c
  Author: alx32 <103613512+alx32 at users.noreply.github.com>
  Date:   2025-04-04 (Fri, 04 Apr 2025)

  Changed paths:
    M lld/MachO/OutputSegment.cpp
    M lld/test/MachO/arm64-objc-stubs.s

  Log Message:
  -----------
  [lld-macho] Fix code section ordering in output binary (#134010)

In `OutputSegment.cpp`, we need to ensure a specific order for certain
sections. The current sorting logic incorrectly prioritizes code
sections over explicitly defined section orders. This is problematic
because the `__objc_stubs` section is both a code section *and* has a
specific ordering requirement. The current logic would incorrectly
prioritize its code section status, causing it to be sorted *before* the
`__stubs` section. This incorrect ordering breaks the branch extension
algorithm, ultimately leading to linker failures due to relocation
errors.

We also modify the `lld/test/MachO/arm64-objc-stubs.s` test to ensure
correct section ordering.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications