[all-commits] [llvm/llvm-project] c14b6e: [lldb][NFC] Move ShouldShow/ShouldSelect logic int...

[Felipe de Azevedo Piovezan via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c14b6e90bd140c2290258fa9dbe0fc1ad8939111
      https://github.com/llvm/llvm-project/commit/c14b6e90bd140c2290258fa9dbe0fc1ad8939111
  Author: Felipe de Azevedo Piovezan <fpiovezan at apple.com>
  Date:   2025-04-03 (Thu, 03 Apr 2025)

  Changed paths:
    M lldb/include/lldb/Target/StopInfo.h
    M lldb/source/Target/Process.cpp
    M lldb/source/Target/StopInfo.cpp

  Log Message:
  -----------
  [lldb][NFC] Move ShouldShow/ShouldSelect logic into Stopinfo (#134160)

This NFC patch simplifies the main loop in HandleProcessStateChanged
event by moving duplicated code into the StopInfo class, also allowing
StopInfo subclasses to override behavior.

More specifically, two functions are created:

* ShouldShow: should a Thread with such StopInfo should be printed when
the debugger stops? Currently, no StopInfo subclasses override this, but
a subsequent patch will fix a bug by making StopInfoBreakpoint check
whether the breakpoint is internal.

* ShouldSelect: should a Thread with such a StopInfo be selected? This
is currently overridden by StopInfoUnixSignal but will, in the future,
be overridden by StopInfoBreakpoint.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications