[all-commits] [llvm/llvm-project] b55bab: [lldb] Fix plugin manager test failure on windows ...

[David Peixotto via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b55bab229228218341e2f24fc8529c7aaab51e2f
      https://github.com/llvm/llvm-project/commit/b55bab229228218341e2f24fc8529c7aaab51e2f
  Author: David Peixotto <peix at meta.com>
  Date:   2025-04-02 (Wed, 02 Apr 2025)

  Changed paths:
    M lldb/unittests/Core/PluginManagerTest.cpp

  Log Message:
  -----------
  [lldb] Fix plugin manager test failure on windows (#134173)

This is an attempt to fix a test failure from #133794 when running on
windows builds. I suspect we are running into a case where the
[ICF](https://learn.microsoft.com/en-us/cpp/build/reference/opt-optimizations?view=msvc-170)
optimization kicks in and combines the CreateSystemRuntimePlugin*
functions into a single address. This means that we cannot uniquely
unregister the plugin based on its create function address.

The fix is have each create function return a different (bogus) value.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications