[all-commits] [llvm/llvm-project] a85856: [llvm][utils] skip revert-checking reverts across ...

[George Burgess IV via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a8585654c2be671d78206666223dae28fe3ac511
      https://github.com/llvm/llvm-project/commit/a8585654c2be671d78206666223dae28fe3ac511
  Author: George Burgess IV <george.burgess.iv at gmail.com>
  Date:   2025-04-02 (Wed, 02 Apr 2025)

  Changed paths:
    M llvm/utils/revert_checker.py

  Log Message:
  -----------
  [llvm][utils] skip revert-checking reverts across branches (#134108)

e2ba1b6ffde4ec607342b1b746d1b57f0f04390a references that it reverts a
commit that's not a parent of e2ba1b6ffde4ec607342b1b746d1b57f0f04390a.

Functionally, this can (and demonstrably does) work(*), but from the
standpoint of the revert checker, it's nonsense. Print a `logging.error`
when it's detected.

Tested by running the revert checker against a commit range that
includes the aforementioned commit; the logging.error was fired
appropriately.

(*) - the specifics here are:
- the _SHA_ that was referenced was on a non-main branch, but
- the commit from the non-main branch was merged into the non-main
branch from main
- ...so the _functional_ commit being reverted was originally landed on
main, but the _SHA_ referenced from main was from a branch that was cut
before the reverted-commit was landed on main



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications