[all-commits] [llvm/llvm-project] c87dc2: [lldb-dap] Speed up TestDAP_Progress (#134048)

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Wed Apr 2 12:42:08 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c87dc2b7d4ac0131cb97f096be522a50a4b3068b
      https://github.com/llvm/llvm-project/commit/c87dc2b7d4ac0131cb97f096be522a50a4b3068b
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2025-04-02 (Wed, 02 Apr 2025)

  Changed paths:
    M lldb/test/API/tools/lldb-dap/progress/Progress_emitter.py
    M lldb/test/API/tools/lldb-dap/progress/TestDAP_Progress.py

  Log Message:
  -----------
  [lldb-dap] Speed up TestDAP_Progress (#134048)

While trying to make progress on #133782, I noticed that
TestDAP_Progress was taking 90 seconds to complete. This patch brings
that down to 10 seocnds by making the following changes:

1. Don't call `wait_for_event` with a 15 second timeout. By the time we
call this, all progress events have been emitted, which means that we're
just sitting there until we hit the timeout.

2. Don't use 10 steps (= 10 seconds) for indeterminate progress. We have
two indeterminate progress tests so that's 6 seconds instead of 20.

3. Don't launch the process over and over. Once we have a dap session,
we can clear the progress vector and emit new progress events.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list