[all-commits] [llvm/llvm-project] 58df0e: Define LLVM_ABI and CLANG_ABI for __EMSCRIPTEN__ b...

[Anutosh Bhat via All-commits]

  Branch: refs/heads/release/20.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247
      https://github.com/llvm/llvm-project/commit/58df0ef89dd64126512e4ee27b4ac3fd8ddf6247
  Author: Anutosh Bhat <andersonbhat491 at gmail.com>
  Date:   2025-04-01 (Tue, 01 Apr 2025)

  Changed paths:
    M clang/include/clang/Support/Compiler.h
    M llvm/include/llvm/Support/Compiler.h

  Log Message:
  -----------
  Define LLVM_ABI and CLANG_ABI for __EMSCRIPTEN__ builds (#131578)

While building llvm (clang, lld) against emscripten we see this
[error](https://github.com/emscripten-forge/recipes/actions/runs/13803029307/job/38608794602#step:9:1715)

```
 │ │ In file included from $SRC_DIR/llvm/lib/Frontend/OpenACC/ACC.cpp:9:
 │ │ $SRC_DIR/build/include/llvm/Frontend/OpenACC/ACC.h.inc:192:1: error: unknown type name 'LLVM_ABI'
 │ │   192 | LLVM_ABI Directive getOpenACCDirectiveKind(llvm::StringRef Str);
 │ │       | ^
 │ │ $SRC_DIR/build/include/llvm/Frontend/OpenACC/ACC.h.inc:192:19: error: expected ';' after top level declarator
 │ │   192 | LLVM_ABI Directive getOpenACCDirectiveKind(llvm::StringRef Str);
 │ │       |                   ^
 ```

Now this was happening because we weren't defining LLVM_ABI correctly when building against emscripten. If you see [llvm/Support/Compiler.h](https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/Support/Compiler.h#L206-L210), the condition only checked for the platform __WASM__ . Now Emscripten targets WebAssembly but doesn't imply the platform by default so the check isn't complete to define LLVM_ABI.

The successful build after using this patch can be seen [here](https://github.com/emscripten-forge/recipes/actions/runs/13805214092/job/38614585621)

(cherry picked from commit e57cd100ca297cf81854e35cccbf703edddd4aad)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications