[all-commits] [llvm/llvm-project] 179062: [mlir][bazel] add alwayslink=True to mlir-runner u...

[Jeremy Kun via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 179062b2dc9405a81cf44dbe676817806a4e7c6a
      https://github.com/llvm/llvm-project/commit/179062b2dc9405a81cf44dbe676817806a4e7c6a
  Author: Jeremy Kun <jkun at google.com>
  Date:   2025-04-01 (Tue, 01 Apr 2025)

  Changed paths:
    M utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

  Log Message:
  -----------
  [mlir][bazel] add alwayslink=True to mlir-runner utils (#133787)

MacOS platforms using mlir-runner in lit tests consistently hit the
following error:

```
# .---command stderr------------
# | JIT session error: Symbols not found: [ __mlir_ciface_printMemrefI32 ]
# | Error: Failed to materialize symbols: { (main, { __mlir_printMemrefI32, ... }) }
# `-----------------------------
```

https://github.com/google/heir/issues/1521#issuecomment-2751303404
confirms the issue is fixed by using `alwayslink` on these two targets,
and I confirmed on a separate Apple M1 (OSX version Sequoia 15.3.2.).

I'm not an expert on the mlir runner internals, but given the
mlir-runner is purely for testing, and alwayslink at worst adds some
overhead by not removing symbols, it seems low risk.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications