[all-commits] [llvm/llvm-project] 64adfc: IRNormalizer: Replace cl::opts with pass parameters

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue Apr 1 00:22:20 PDT 2025


  Branch: refs/heads/users/arsenm/ir-normalizer/use-pass-params-instead-of-cl-opts
  Home:   https://github.com/llvm/llvm-project
  Commit: 64adfcf38a520adc1ba2b0ba6402fac6b3547121
      https://github.com/llvm/llvm-project/commit/64adfcf38a520adc1ba2b0ba6402fac6b3547121
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-04-01 (Tue, 01 Apr 2025)

  Changed paths:
    M llvm/include/llvm/Transforms/Utils/IRNormalizer.h
    M llvm/lib/Passes/PassBuilder.cpp
    M llvm/lib/Passes/PassRegistry.def
    M llvm/lib/Transforms/Utils/IRNormalizer.cpp
    A llvm/test/Transforms/IRNormalizer/pass-parameters.ll
    M llvm/test/Transforms/IRNormalizer/reordering.ll

  Log Message:
  -----------
  IRNormalizer: Replace cl::opts with pass parameters

Not sure why the "fold-all" option naming didn't match the
variable "FoldPreOutputs", but I've preserved the difference.

More annoyingly, the pass name "normalize" does not match the pass
name IRNormalizer and should probably be fixed one way or the other.

Also the existing test coverage for the flags is lacking. I've added
a test that shows they parse, but we should have tests that they
do something.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list