[all-commits] [llvm/llvm-project] 3acccf: [MC] Don't print () around $ names

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3acccf042ab8a7b7e663bb2b2fac328d9bf65b38
      https://github.com/llvm/llvm-project/commit/3acccf042ab8a7b7e663bb2b2fac328d9bf65b38
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-03-30 (Sun, 30 Mar 2025)

  Changed paths:
    M llvm/include/llvm/MC/MCAsmInfo.h
    M llvm/include/llvm/MC/MCExpr.h
    M llvm/lib/MC/MCExpr.cpp
    M llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCExpr.cpp
    M llvm/lib/Target/Mips/MCTargetDesc/MipsInstPrinter.cpp
    M llvm/lib/Target/Mips/MCTargetDesc/MipsMCExpr.cpp
    M llvm/lib/Target/NVPTX/MCTargetDesc/NVPTXMCAsmInfo.cpp
    M llvm/lib/Target/Xtensa/MCTargetDesc/XtensaInstPrinter.cpp
    M llvm/test/CodeGen/AArch64/arm64ec-exit-thunks.ll
    M llvm/test/CodeGen/AArch64/arm64ec-hybrid-patchable.ll
    M llvm/test/CodeGen/AArch64/pr58516.ll
    M llvm/test/CodeGen/AArch64/win-catchpad-nested-cxx.ll
    M llvm/test/CodeGen/AArch64/wineh-catchret-label-generation.ll
    M llvm/test/CodeGen/AArch64/wineh-try-catch.ll
    M llvm/test/CodeGen/Mips/ehframe-indirect.ll
    M llvm/test/CodeGen/Mips/indirect-jump-hazard/long-branch.ll
    M llvm/test/CodeGen/Mips/jtstat.ll
    M llvm/test/CodeGen/Mips/load-store-left-right.ll
    M llvm/test/CodeGen/Mips/longbranch.ll
    M llvm/test/CodeGen/Mips/mcount.ll
    M llvm/test/CodeGen/Mips/micromips-mtc-mfc.ll
    M llvm/test/CodeGen/Mips/mips16ex.ll
    M llvm/test/CodeGen/Mips/reloc-jalr.ll
    M llvm/test/CodeGen/Mips/shrink-wrapping.ll
    M llvm/test/CodeGen/Mips/unalignedload.ll
    M llvm/test/CodeGen/Mips/xray-mips-attribute-instrumentation.ll
    M llvm/test/CodeGen/X86/catchpad-reuse.ll
    M llvm/test/CodeGen/X86/dollar-name.ll
    M llvm/test/CodeGen/X86/seh-unwind-inline-asm-codegen.ll
    M llvm/test/CodeGen/X86/stack-coloring-wineh.ll
    M llvm/test/CodeGen/X86/win-catchpad-nested-cxx.ll
    M llvm/test/CodeGen/X86/win-catchpad.ll
    M llvm/test/CodeGen/X86/win-cleanuppad.ll
    M llvm/test/CodeGen/X86/win-funclet-cfi.ll
    M llvm/test/CodeGen/X86/win32-eh.ll
    M llvm/test/CodeGen/X86/windows-seh-EHa-CppCatchDotDotDot.ll
    M llvm/test/CodeGen/X86/windows-seh-EHa-CppDtors01.ll
    M llvm/test/DebugInfo/COFF/jump-table.ll
    M llvm/test/MC/ARM/arm-branches.s
    M llvm/test/MC/AsmParser/dollars-in-identifiers.s
    M llvm/test/MC/MachO/dollar-identifier.s
    M llvm/test/MC/Mips/expansion-jal-sym-pic.s
    M llvm/test/MC/Mips/macro-div.s
    M llvm/test/MC/Mips/macro-divu.s
    M llvm/test/MC/Mips/macro-rem.s
    M llvm/test/MC/Mips/macro-remu.s
    M llvm/test/MC/Mips/mips-fpu-instructions.s
    M llvm/test/MC/Mips/mips1/valid.s
    M llvm/test/MC/Mips/mips2/valid.s
    M llvm/test/MC/Mips/mips32/valid.s
    M llvm/test/MC/Mips/mips32r2/valid.s
    M llvm/test/MC/Mips/mips32r3/valid.s
    M llvm/test/MC/Mips/mips32r5/valid.s
    M llvm/test/MC/Mips/mips32r6/valid.s
    M llvm/test/MC/Mips/mips64r6/valid.s
    M llvm/test/MC/Mips/mips_directives.s
    M llvm/test/MC/Mips/reloc-directive-label-offset.s

  Log Message:
  -----------
  [MC] Don't print () around $ names

This MIPS behavior from edb9d84dcc4824865e86f963e52d67eb50dde7f5 (2010)
is obsoleted and misleading. This caused confusion in
https://reviews.llvm.org/D123702 ([NVPTX] Disable parens for identifiers
starting with '$')

Note: $tmp was rejected by AsmParser before
https://reviews.llvm.org/D75111 (2020)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications