[all-commits] [llvm/llvm-project] e16541: [libc++] fix `flat_set`'s transparent `insert` (#1...

Hui via All-commits all-commits at lists.llvm.org
Sat Mar 29 09:29:52 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e16541e1a6c02b32124e8893b29882bff072fd46
      https://github.com/llvm/llvm-project/commit/e16541e1a6c02b32124e8893b29882bff072fd46
  Author: Hui <hui.xie1990 at gmail.com>
  Date:   2025-03-29 (Sat, 29 Mar 2025)

  Changed paths:
    M libcxx/include/__flat_set/flat_set.h
    M libcxx/test/std/containers/container.adaptors/flat.set/flat.set.modifiers/insert_transparent.pass.cpp
    M libcxx/test/std/containers/container.adaptors/flat.set/helpers.h

  Log Message:
  -----------
  [libc++] fix `flat_set`'s transparent `insert` (#133402)

Unlike `flat_map` and `flat_multimap`, The two function template
overloads `flat_set::insert`'s wording strongly suggest we should use
the transparent comparator
https://eel.is/c++draft/flat.set#modifiers-1

Both the code and the tests were not using the transparent comparator,
which needs to be fixed



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list