[all-commits] [llvm/llvm-project] 75ca08: [RISCV][Xqccmp] Correctly Parse/Disassemble pushfp...

[Sam Elliott via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 75ca080daba6585d0a6522187aab4bc781ba4103
      https://github.com/llvm/llvm-project/commit/75ca080daba6585d0a6522187aab4bc781ba4103
  Author: Sam Elliott <quic_aelliott at quicinc.com>
  Date:   2025-03-27 (Thu, 27 Mar 2025)

  Changed paths:
    M llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
    M llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp
    M llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp
    M llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h
    M llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCCodeEmitter.cpp
    M llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
    M llvm/lib/Target/RISCV/RISCVInstrInfoXqccmp.td
    M llvm/lib/Target/RISCV/RISCVInstrInfoZc.td
    A llvm/test/MC/Disassembler/RISCV/xqccmp-invalid-rlist.txt
    M llvm/test/MC/RISCV/rv32xqccmp-invalid.s
    M llvm/test/MC/RISCV/rv32xqccmp-valid.s
    M llvm/test/MC/RISCV/rv64e-xqccmp-valid.s
    M llvm/test/MC/RISCV/rv64xqccmp-valid.s

  Log Message:
  -----------
  [RISCV][Xqccmp] Correctly Parse/Disassemble pushfp (#133188)

In the `qc.cm.pushfp` instruction, it is like `cm.pushfp` except in one
important way - `qc.cm.pushfp {ra}, -N*16` is not a valid encoding,
because this would update `s0`/`fp`/`x8` without saving it.

This change now correctly rejects this variant of the instruction, both
during parsing and during disassembly. I also implemented validation for
immediates that represent register lists (both kinds), which may help to
catch bugs in the future.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications