[all-commits] [llvm/llvm-project] fc33aa: [llvm][cmake] Quote CMAKE_CXX_COMPILER_ID in strin...

[Michael Buch via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fc33aa9684243dcce84b81f11c004061350b945a
      https://github.com/llvm/llvm-project/commit/fc33aa9684243dcce84b81f11c004061350b945a
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2025-03-27 (Thu, 27 Mar 2025)

  Changed paths:
    M llvm/cmake/modules/CheckProblematicConfigurations.cmake

  Log Message:
  -----------
  [llvm][cmake] Quote CMAKE_CXX_COMPILER_ID in string comparison (#133332)

We're seeing following configuration error when building the `runtimes`
target on our buildbots:
```
CMake Error at /Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-sanitized/llvm-project/llvm/cmake/modules/CheckProblematicConfigurations.cmake:14 (if):
  if given arguments:

    "STREQUAL" "MSVC"

  Unknown arguments specified
Call Stack (most recent call first):
  /Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-sanitized/llvm-project/llvm/cmake/modules/HandleLLVMOptions.cmake:10 (include)
  CMakeLists.txt:175 (include)
```

If I understand correctly this happens because ${CMAKE_CXX_COMPILER_ID}
is empty. Quoting it should make the comparison work for those cases.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications