[all-commits] [llvm/llvm-project] 50ea77: [opt][timers] Fix time-passes.ll test failing on r...

[Alan Zhao via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 50ea777e40dd0732fe08457d6326db538f0369b0
      https://github.com/llvm/llvm-project/commit/50ea777e40dd0732fe08457d6326db538f0369b0
  Author: Alan Zhao <ayzhao at google.com>
  Date:   2025-03-27 (Thu, 27 Mar 2025)

  Changed paths:
    M llvm/test/Other/time-passes.ll
    M llvm/tools/opt/NewPMDriver.cpp

  Log Message:
  -----------
  [opt][timers] Fix time-passes.ll test failing on reversed iterators (#131941)

After https://github.com/llvm/llvm-project/pull/131217 was submitted,
time-passes.ll fails because `opt` prints `-time-report` when
`ManagedTimerGlobals` is destroyed. `ManagedTimerGlobals` stores
`TimerGroup`s in an unordered map, so the ordering of the output
`TimerGroup`s depends on the underlying iterator.

To fix this, we do what Clang does and use
`llvm::TimerGroup::printAll(...)`, which *is* deterministic. This is
also what Clang does. This does put move analysis section before the
pass section for `-time-report`, but again, this is also what Clang
currently does.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications