[all-commits] [llvm/llvm-project] d0aa1f: [Clang] Make `--lto-partitions` only default for H...

[Joseph Huber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d0aa1f9c43a4a5709e060aea6c844bdcc70bcd0e
      https://github.com/llvm/llvm-project/commit/d0aa1f9c43a4a5709e060aea6c844bdcc70bcd0e
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2025-03-27 (Thu, 27 Mar 2025)

  Changed paths:
    M clang/lib/Driver/ToolChains/AMDGPU.cpp
    M clang/test/Driver/amdgpu-toolchain.c
    M clang/test/Driver/hip-toolchain-rdc.hip
    M libc/startup/gpu/CMakeLists.txt

  Log Message:
  -----------
  [Clang] Make `--lto-partitions` only default for HIP (#133164)

Summary:
The default behavior for LTO on other targets does not specify the
number of LTO partitions. Recent changes made this default to 8 on
AMDGPU which had some issues with the `libc` project. The option to
disable this is HIP only so I think for now we should restrict this just
to HIP.

I'm definitely on board with getting some more parallelism here, but I
think it should probably be restricted to just offloading languages. The
new driver goes through the `--target=amdgcn-amd-amdhsa` for its output,
which means we'd need to forward the default somehow.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications