[all-commits] [llvm/llvm-project] e696f4: [llvm-exegesis] Fix LBR checks/test

[Aiden Grossman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e696f4e5008c21b8edee089fb80d4e2e0d998e20
      https://github.com/llvm/llvm-project/commit/e696f4e5008c21b8edee089fb80d4e2e0d998e20
  Author: Aiden Grossman <agrossman154 at yahoo.com>
  Date:   2025-03-25 (Tue, 25 Mar 2025)

  Changed paths:
    M llvm/test/tools/llvm-exegesis/X86/lbr/mov-add.s
    M llvm/test/tools/llvm-exegesis/lit.local.cfg

  Log Message:
  -----------
  [llvm-exegesis] Fix LBR checks/test

This patch fixes the LBR check in the local lit config. The test would
segfault as the loop body would be basically empty, causing a divide by
zero error. More investigation is needed there so we do not actually hit
that assertion and report a cleaner error somewhere. Specifying an
actual opcode to benchmark fixes the problem. The test would also fail
as -mcpu was set to the default x86 CPU rather than the one currently
being run on, so it would always fail to find a perf counter. This patch
fixes that by simply removing the -mcpu flag.

Given these issues, I'm not sure these tests have ever run in the ~5
years they have been in tree. There were some issues reported in
\#132861, so I guess we'll see if there are further issues when the
testing becomes more broad.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications