[all-commits] [llvm/llvm-project] ef9c4f: [mlir][spirv] Update assembly format for Image ope...

[Igor Wodiany via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ef9c4f4f5cfeb6e3d194a0bb3098c45a5c75d18f
      https://github.com/llvm/llvm-project/commit/ef9c4f4f5cfeb6e3d194a0bb3098c45a5c75d18f
  Author: Igor Wodiany <igor.wodiany at imgtec.com>
  Date:   2025-03-24 (Mon, 24 Mar 2025)

  Changed paths:
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVImageOps.td
    M mlir/test/Dialect/SPIRV/IR/image-ops.mlir

  Log Message:
  -----------
  [mlir][spirv] Update assembly format for Image operand types (#130758)

In the example below it is not clear that `(f32)` relates to `%arg2` and
not to `vector<2xf32>`:

```mlir
%0 = spirv.ImageSampleImplicitLod %arg0, %arg1 ["Lod"](%arg2) :
  !spirv.sampled_image<...>, vector<2xf32>(f32) -> vector<4xf32>
```

This change applies new format to image operations and image operands
that does not use parenthesis and is less ambiguous:

```mlir
%0 = spirv.ImageSampleImplicitLod %arg0, %arg1 ["Lod"], %arg2 :
  !spirv.sampled_image<...>, vector<2xf32>, f32 -> vector<4xf32>
```



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications