[all-commits] [llvm/llvm-project] cfd53f: [InstCombine] Use MapVector for SourceAggregates. ...

Florian Hahn via All-commits all-commits at lists.llvm.org
Sun Mar 23 04:17:11 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cfd53ffb44f5d3c438c909b2bc9ae5604f452f39
      https://github.com/llvm/llvm-project/commit/cfd53ffb44f5d3c438c909b2bc9ae5604f452f39
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2025-03-23 (Sun, 23 Mar 2025)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp

  Log Message:
  -----------
  [InstCombine] Use MapVector for SourceAggregates. (#132564)

foldAggregateConstructionIntoAggregateReuse iterates over the entries of
SourceAggregates and the order of inserted instructions depends on the
order of the iterator. Using a regular DenseMap can lead to
non-deterministic value naming/numbering.

I don't think it can actually impact the generated binary, but it makes
diffing IR more difficult.

PR: https://github.com/llvm/llvm-project/pull/132564



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list