[all-commits] [llvm/llvm-project] d4ce57: [libc] Fix unresolved stdio symbols (#132403)

[Joseph Huber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d4ce57cb98dbe753d246ae5395cc5ac6da8afa88
      https://github.com/llvm/llvm-project/commit/d4ce57cb98dbe753d246ae5395cc5ac6da8afa88
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2025-03-21 (Fri, 21 Mar 2025)

  Changed paths:
    M libc/src/stdio/CMakeLists.txt
    M libc/src/stdio/generic/CMakeLists.txt

  Log Message:
  -----------
  [libc] Fix unresolved stdio symbols (#132403)

Summary:
We have 'generic' implementations for some functions stdio functions.
The current logic mandates that all generic functions are implemented by
the target. This obviously isn't true and this caused the GPU builds to
fail once baremtal added some extra ones.

This patch changes the logic to always include the generic sources only
if they aren't already defined. This can probably be cleaned up and
formalized later, since this pattern is copied in many places, but for
now this fixes the failing GPU build bots.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications