[all-commits] [llvm/llvm-project] 909bff: gn build: libcxx: Sync file list and always define...

Peter Collingbourne via All-commits all-commits at lists.llvm.org
Thu Mar 20 10:51:10 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 909bff82b06aae32d27dfae0e878c3ffc40c4ee2
      https://github.com/llvm/llvm-project/commit/909bff82b06aae32d27dfae0e878c3ffc40c4ee2
  Author: Peter Collingbourne <pcc at google.com>
  Date:   2025-03-20 (Thu, 20 Mar 2025)

  Changed paths:
    M llvm/utils/gn/secondary/libcxx/include/BUILD.gn

  Log Message:
  -----------
  gn build: libcxx: Sync file list and always define _LIBCPP_ABI_VERSION.

The CMake side always defines _LIBCPP_ABI_VERSION. If we do not, we will
at least get -Wundef warnings in the test suite (upgraded to errors)
and it looks like we will end up building the library incorrectly as well.

With that, most of the libc++ test suite passes (with a manually written
lit.site.cfg) aside from some parts related to C++ modules which we
don't support yet.

Reviewers: nico, aeubanks

Reviewed By: aeubanks

Pull Request: https://github.com/llvm/llvm-project/pull/132135



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list