[all-commits] [llvm/llvm-project] 460c0f: [lldb] Move two methods from Platfrom -> Host (NFC...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 460c0f567cc83378d4aafd9fba95561bacf57fe4
      https://github.com/llvm/llvm-project/commit/460c0f567cc83378d4aafd9fba95561bacf57fe4
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M lldb/include/lldb/Host/HostInfoBase.h
    M lldb/include/lldb/Host/macosx/HostInfoMacOSX.h
    M lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm
    M lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.h
    M lldb/unittests/Host/HostInfoTest.cpp
    M lldb/unittests/Platform/PlatformDarwinTest.cpp

  Log Message:
  -----------
  [lldb] Move two methods from Platfrom -> Host (NFC) (#132119)

This moves two functions from Platform to Host:

  1. GetCurrentXcodeToolchainDirectory
  2. GetCurrentCommandLineToolsDirectory.

These two functions caused a layering violation in the Swift fork, which
added a dependency from lldbHost to lldbPlatform. As show by this PR,
there's no need for these two functions to live in Platform, and we
already have similar functions in Host.

We have various layering violations but this one is particularly bad,
because lldb-dap started depending on lldbHost. On the Swift fork, this
library was depending on lldbPlatform which pulled in various Swift
files, which libLLDB needs, but lldb-dap itself does not. We were
missing RPATHs to resume them, so in the current nightly, lldb-dap
crashes because the dynamic loader can't find the missing Swift libs.

rdar://146537366



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications