[all-commits] [llvm/llvm-project] aed180: [flang][OpenMP] Clone reduction info from nested `...

[Kareem Ergawy via All-commits]

  Branch: refs/heads/users/ergawy/fix_teams_loop_reduction
  Home:   https://github.com/llvm/llvm-project
  Commit: aed180b0b761023b0baf84ada2a9ee2fd5ca5ed8
      https://github.com/llvm/llvm-project/commit/aed180b0b761023b0baf84ada2a9ee2fd5ca5ed8
  Author: ergawy <kareem.ergawy at amd.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M flang/lib/Optimizer/OpenMP/GenericLoopConversion.cpp
    M flang/test/Lower/OpenMP/loop-directive.f90

  Log Message:
  -----------
  [flang][OpenMP] Clone reduction info from nested `loop` ops to parent `teams` ops

Fixes a bug in reductions when converting `teams loop` constructs with
`reduction` clauses.

According to the spec (v5.2, p340, 36):

```
The effect of the reduction clause is as if it is applied to all leaf
constructs that permit the clause, except for the following constructs:
* ....
* The teams construct, when combined with the loop construct.
```

Therefore, for a combined directive similar to: `!$omp teams loop
reduction(...)`, the earlier stages of the compiler assign the `reduction`
clauses only to the `loop` leaf and not to the `teams` leaf.

On the other hand, if we have a combined construct similar to: `!$omp teams
distribute parallel do`, the `reduction` clauses are assigned both to the
`teams` and the `do` leaves. We need to match this behavior when we convert
`teams` op with a nested `loop` op since the target set of constructs/ops
will be incorrect without moving the reductions up to the `teams` op as
well.

This PR introduces a pattern that does exactly this. Given the following input:
```
omp.teams {
  omp.loop reduction(@red_sym %red_op -> %red_arg : !fir.ref<i32>) {
    omp.loop_nest ... {
      ...
    }
  }
}
```
this pattern updates the `omp.teams` op in-place to:
```
omp.teams reduction(@red_sym %red_op -> %teams_red_arg : !fir.ref<i32>) {
  omp.loop reduction(@red_sym %teams_red_arg -> %red_arg : !fir.ref<i32>) {
    omp.loop_nest ... {
      ...
    }
  }
}
```

Note the following:
* The nested `omp.loop` is not rewritten by this pattern, this happens
  through `GenericLoopConversionPattern`.
* The reduction info are cloned from the nested `omp.loop` op to the parent
  `omp.teams` op.
* The reduction operand of the `omp.loop` op is updated to be the **new**
  reduction block argument of the `omp.teams` op.


  Commit: 37f2f8ebaeb64a812875eea041176480464d9fa6
      https://github.com/llvm/llvm-project/commit/37f2f8ebaeb64a812875eea041176480464d9fa6
  Author: ergawy <kareem.ergawy at amd.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M flang/lib/Optimizer/OpenMP/GenericLoopConversion.cpp

  Log Message:
  -----------
  Handle review comments


Compare: https://github.com/llvm/llvm-project/compare/21b30b75c78b...37f2f8ebaeb6

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications