[all-commits] [llvm/llvm-project] 547583: [sancov] Use comdats when one already exists (#131...

[Reid Kleckner via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5475834737663c0da3c444fcf1c8ab5567c39136
      https://github.com/llvm/llvm-project/commit/5475834737663c0da3c444fcf1c8ab5567c39136
  Author: Reid Kleckner <rnk at google.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
    M llvm/test/Instrumentation/SanitizerCoverage/interposable-symbol.ll

  Log Message:
  -----------
  [sancov] Use comdats when one already exists (#131929)

This code avoids adding comdat groups to interposable linkage types
(weak, linkonce (non-ODR)) to avoid changing semantics, since comdat
elimination happens before weak/strong prevailaing symbol resolution.
However, if the function is already in a comdat, we can add to the group
without changing the semantics of the linked program.

Fixes an issue uncovered in PR #126240



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications