[all-commits] [llvm/llvm-project] 7af0bf: [lldb-dap] Ensure logging statements are written a...

John Harrison via All-commits all-commits at lists.llvm.org
Wed Mar 19 09:17:15 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7af0bfe62fff676c66a5394995b03030cf5baef4
      https://github.com/llvm/llvm-project/commit/7af0bfe62fff676c66a5394995b03030cf5baef4
  Author: John Harrison <harjohn at google.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M lldb/tools/lldb-dap/CMakeLists.txt
    M lldb/tools/lldb-dap/DAP.cpp
    M lldb/tools/lldb-dap/DAP.h
    M lldb/tools/lldb-dap/DAPForward.h
    A lldb/tools/lldb-dap/DAPLog.cpp
    M lldb/tools/lldb-dap/DAPLog.h
    M lldb/tools/lldb-dap/EventHelper.cpp
    M lldb/tools/lldb-dap/Transport.cpp
    M lldb/tools/lldb-dap/Transport.h
    M lldb/tools/lldb-dap/lldb-dap.cpp

  Log Message:
  -----------
  [lldb-dap] Ensure logging statements are written as a single chunk. (#131916)

I noticed this while debugging some unit tests that the logs
occasionally would intersperse two log statements.

Previously, it was possible for a log statement to have two messages
interspersed since the timestamp and log statement were two different
writes to the log stream.

I created a Log helper to ensure we have a lock while attempting to write
to the logs.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list