[all-commits] [llvm/llvm-project] 8f66fb: [GlobalMerge] Fix handling of const options

Nikita Popov via All-commits all-commits at lists.llvm.org
Tue Mar 18 07:07:06 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8f66fb784291c897a965a9ee4c280e314dc8cee4
      https://github.com/llvm/llvm-project/commit/8f66fb784291c897a965a9ee4c280e314dc8cee4
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
    M llvm/include/llvm/CodeGen/GlobalMerge.h
    M llvm/lib/CodeGen/GlobalMerge.cpp
    M llvm/lib/Passes/PassBuilder.cpp
    M llvm/lib/Passes/PassRegistry.def
    A llvm/test/Transforms/GlobalMerge/constants.ll

  Log Message:
  -----------
  [GlobalMerge] Fix handling of const options

For the NewPM, the merge-const option was assigned to an unused
option field. Assign it to the correct one. The merge-const-aggressive
option was not supported -- and invalid options were silently ignored.
Accept it and error on invalid options.

For the LegacyPM, the corresponding cl::opt options were ignored when
called via opt rather than llc.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list