[all-commits] [llvm/llvm-project] d1156f: Revert "[libc++] Optimize num_put integral functio...

[Alexander Kornienko via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d1156fcb56891fb1a426c3e8331a51d47f98a1b8
      https://github.com/llvm/llvm-project/commit/d1156fcb56891fb1a426c3e8331a51d47f98a1b8
  Author: Alexander Kornienko <alexfh at google.com>
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
    M libcxx/docs/ReleaseNotes/20.rst
    M libcxx/include/__charconv/tables.h
    M libcxx/include/__charconv/to_chars_base_10.h
    M libcxx/include/__charconv/to_chars_integral.h
    M libcxx/include/__charconv/to_chars_result.h
    M libcxx/include/__charconv/traits.h
    M libcxx/include/__format/formatter_floating_point.h
    M libcxx/include/__format/formatter_integral.h
    M libcxx/include/__format/formatter_output.h
    M libcxx/include/locale
    M libcxx/include/module.modulemap
    R libcxx/test/benchmarks/locale/num_put.bench.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_pointer.pass.cpp

  Log Message:
  -----------
  Revert "[libc++] Optimize num_put integral functions" (#131613)

Reverts llvm/llvm-project#120859

This change breaks formatting of `0` with `std::showbase` + `std::hex`
or `std::oct`, as well as `+0` with `std::showpos`. I believe the new
behavior is violating the standard. See
https://github.com/llvm/llvm-project/pull/120859#issuecomment-2723970242
and later comments for details and explanation.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications