[all-commits] [llvm/llvm-project] 36c156: [OffloadBundler] Rework the ctor of `OffloadTarget...

[Shilei Tian via All-commits]

  Branch: refs/heads/users/shiltian/rework-offloadtargetinfo-ctor
  Home:   https://github.com/llvm/llvm-project
  Commit: 36c15623d308ecacdfe1fdd18a085dfd3d5c2712
      https://github.com/llvm/llvm-project/commit/36c15623d308ecacdfe1fdd18a085dfd3d5c2712
  Author: Shilei Tian <i at tianshilei.me>
  Date:   2025-03-17 (Mon, 17 Mar 2025)

  Changed paths:
    M clang/docs/ClangOffloadBundler.rst
    M clang/lib/Driver/OffloadBundler.cpp
    M clang/lib/Driver/ToolChains/Clang.cpp
    M clang/lib/Driver/ToolChains/CommonArgs.cpp
    M clang/lib/Driver/ToolChains/HIPUtility.cpp
    M clang/test/Driver/clang-offload-bundler-asserts-on.c
    M clang/test/Driver/clang-offload-bundler-standardize.c
    M clang/test/Driver/clang-offload-bundler.c
    M clang/test/Driver/hip-link-bc-to-bc.hip
    M clang/test/Driver/hip-link-bundle-archive.hip
    M clang/test/Driver/hip-offload-compress-zlib.hip
    M clang/test/Driver/hip-offload-compress-zstd.hip
    M clang/test/Driver/hip-rdc-device-only.hip
    M clang/test/Driver/hip-toolchain-rdc-separate.hip
    M llvm/utils/lit/lit/llvm/config.py

  Log Message:
  -----------
  [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to support generic target

The current parsing of target string assumes to be in a form of
`kind-triple-targetid:feature`, such as
`hipv4-amdgcn-amd-amdhsa-gfx1030:+xnack`. Specifically, the target id does not
contain any `-`, which is not the case for generic target. Also, a generic
target may contain one or more `-`, such as `gfx10-3-generic` and
`gfx12-generic`. As a result, we can no longer depend on `rstrip` to get things
work right. This patch reworks the logic to parse the target string to make it
more robust, as well as supporting generic target.


  Commit: 099faed9be5ab1847fa843e08e2c33dd88862371
      https://github.com/llvm/llvm-project/commit/099faed9be5ab1847fa843e08e2c33dd88862371
  Author: Shilei Tian <i at tianshilei.me>
  Date:   2025-03-17 (Mon, 17 Mar 2025)

  Changed paths:
    M clang/docs/ClangOffloadBundler.rst

  Log Message:
  -----------
  Update document


  Commit: 8c59de8517860c77aa711fa5736d56d68ad89c6e
      https://github.com/llvm/llvm-project/commit/8c59de8517860c77aa711fa5736d56d68ad89c6e
  Author: Shilei Tian <i at tianshilei.me>
  Date:   2025-03-17 (Mon, 17 Mar 2025)

  Changed paths:
    M clang/include/clang/Driver/OffloadBundler.h
    M clang/lib/Driver/OffloadBundler.cpp
    M clang/test/Driver/clang-offload-bundler.c
    M clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp

  Log Message:
  -----------
  Add bundle id check such as it should not crash when given a malformat bundle id


  Commit: 29c3cac94127256a45084a81baf2e01d00dc0ada
      https://github.com/llvm/llvm-project/commit/29c3cac94127256a45084a81baf2e01d00dc0ada
  Author: Shilei Tian <i at tianshilei.me>
  Date:   2025-03-17 (Mon, 17 Mar 2025)

  Changed paths:
    M clang/test/Driver/clang-offload-bundler.c

  Log Message:
  -----------
  Fix a test issue


Compare: https://github.com/llvm/llvm-project/compare/44bcda01654a...29c3cac94127

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications