[all-commits] [llvm/llvm-project] 270999: [NFC][analyzer] Framework for multipart checkers (...

[Donát Nagy via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 27099982da2f5a6c2d282d6b385e79d080669546
      https://github.com/llvm/llvm-project/commit/27099982da2f5a6c2d282d6b385e79d080669546
  Author: Donát Nagy <donat.nagy at ericsson.com>
  Date:   2025-03-17 (Mon, 17 Mar 2025)

  Changed paths:
    M clang/include/clang/StaticAnalyzer/Core/BugReporter/BugType.h
    M clang/include/clang/StaticAnalyzer/Core/Checker.h
    M clang/include/clang/StaticAnalyzer/Core/CheckerManager.h
    M clang/lib/StaticAnalyzer/Checkers/DivZeroChecker.cpp
    M clang/lib/StaticAnalyzer/Core/Checker.cpp

  Log Message:
  -----------
  [NFC][analyzer] Framework for multipart checkers (#130985)

In the static analyzer codebase we have a traditional pattern where a
single checker class (and its singleton instance) acts as the
implementation of several (user-facing or modeling) checkers that have
shared state and logic, but have their own names and can be enabled or
disabled separately.
 
Currently these multipart checker classes all reimplement the same
boilerplate logic to store the enabled/disabled state, the name and the
bug types associated with the checker parts. This commit extends
`CheckerBase`, `BugType` and the checker registration process to offer
an easy-to-use alternative to that boilerplate (which includes the ugly
lazy initialization of `mutable std::unique_ptr<BugType>`s).
 
In this new framework the single-part checkers are internally
represented as "multipart checkers with just one part" (because this way
I don't need to reimplement the same logic twice) but this does not
require any changes in the code of simple single-part checkers.
 
I do not claim that these multi-part checkers are perfect from an
architectural point of view; but they won't suddenly disappear after
many years of existence, so we might as well introduce a clear framework
for them. (Switching to e.g. 1:1 correspondence between checker classes
and checker names would be a prohibitively complex change.)

This PR ports `DivZeroChecker` to the new framework as a proof of
concept. I'm planning to do a series of follow-up commits to port the
rest of the multi-part checker.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications