[all-commits] [llvm/llvm-project] 481a55: [rtsan][Apple] Add interceptor for _os_nospin_lock...

[davidtrevelyan via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 481a55a3d9645a6bc1540d326319b78ad8ed8db1
      https://github.com/llvm/llvm-project/commit/481a55a3d9645a6bc1540d326319b78ad8ed8db1
  Author: davidtrevelyan <davidtrevelyan at users.noreply.github.com>
  Date:   2025-03-13 (Thu, 13 Mar 2025)

  Changed paths:
    M compiler-rt/lib/rtsan/rtsan_interceptors_posix.cpp
    M compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp

  Log Message:
  -----------
  [rtsan][Apple] Add interceptor for _os_nospin_lock_lock (#131034)

Follows the discussion here:
https://github.com/llvm/llvm-project/pull/129309

Recently, the test
`TestRtsan.AccessingALargeAtomicVariableDiesWhenRealtime` has been
failing on newer MacOS versions, because the internal locking mechanism
in `std::atomic<T>::load` (for types `T` that are larger than the
hardware lock-free limit), has changed to a function that wasn't being
intercepted by rtsan.

This PR introduces an interceptor for `_os_nospin_lock_lock`, which is
the new internal locking mechanism.

_Note: we'd probably do well to introduce interceptors for
`_os_nospin_lock_unlock` (and `os_unfair_lock_unlock`) too, which also
appear to have blocking implementations. This can follow in a separate
PR._



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications