[all-commits] [llvm/llvm-project] 34f4ee: [C++20] [Modules] Merge codes to decide if we shou...

[Chuanqi Xu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 34f4ee7c0d98cfbee2bfc5cfee72b8090da68dc2
      https://github.com/llvm/llvm-project/commit/34f4ee7c0d98cfbee2bfc5cfee72b8090da68dc2
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2025-03-13 (Thu, 13 Mar 2025)

  Changed paths:
    M clang/lib/Serialization/ASTWriterDecl.cpp
    M clang/test/Modules/external-but-not-type-external.cppm

  Log Message:
  -----------
  [C++20] [Modules] Merge codes to decide if we should generate decl

There are two piece of codes in ASTWriterDecl to decide whether or not
we should generate a function or a variable in current module unit (or
PCH with object file extension, which is rarely used). One is in
Visit*Decl and One is in `CanElideDef`. Since they are similar it should
be better to merge them.

This was meant to be a NFC patch. But it seems it helped me to find an
existing bug.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications